Allow URLs as source locations

[jvasiljevich]

This PR was made to implement enhancement described in #293

[westeezy]

👍 This change would be very helpful to our project.

[madorb]

This change would be very helpful to MY project

[joelittlejohn]

Thanks for working on this. There's quite a few changes so I'd quite like to give this a thorough look through before merging, but in general I don't see a problem with adding this feature in the way you have.

I noticed that the integration tests are currently failing, could you take a look at this?

[jvasiljevich]

@joelittlejohn thanks for taking a look! Regarding the test failure, it looks like it's only a single test: specifically, the pathWithSpacesInTheNameDoesNotFail test within RegressionIT.

Oddly enough, when run from my IDE, that test also fails on master. It does pass on master when run from the command line though...seems strange. At any rate, I'll take a closer look at it.

[joelittlejohn]

I expect this is something to do with basedir when running in your IDE.

On 26 February 2015 at 22:47, jvasiljevich notifications@github.com wrote:

@joelittlejohn https://github.com/joelittlejohn thanks for taking a
look! Regarding the test failure, it looks like it's only a single test.
Specifically, the pathWithSpacesInTheNameDoesNotFail test that's failing
within RegressionIT.

Oddly enough, when run from my IDE, that test also fails on master. It
does pass on master when run from the command line though...seems strange.
At any rate, I'll take a closer look at it.

—
Reply to this email directly or view it on GitHub
#294 (comment)
.

[jvasiljevich]

Had a chance to look at the failing test this morning. Fixed a url decoding issue in the node naming functionality. Tests are passing now.