Support "required" keyword draft04 array-style when generating constuctors #599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ctors with only required parameters
|
just noticed this one too #379. I think it is the same fix. |
|
Looks like your changes include a test, so we can merge this :) Feel free to compare your changes to #379 and tweak this if there's anything there worth taking. Let me know when your ready and I will review and merge. Thanks for contributing! |
|
I like how that one loops over the JsonNode using ArrayNode interface. It also checks that "required" items are actually textual. I'll incorporate those things. |
loop using Iterable interface of JsonNode instead of using explicit iterator check for textual members inside "required" array.
jjjhhhlll
force-pushed
the
array-style-required-with-constructor
branch
from
b842c0d
to
611142a
Compare
|
Ok. changes complete. |
joelittlejohn
changed the title
|
Sorry, broken builds were something to do with the Sonatype oss-parent pom and an old dependency disappearing from the public apache Maven repo. |
|
No worries. Maven has advantages, but they come with problems like this sometimes. Thanks for your help. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I noticed that the "required" keyword only considers the draft3 style (boolean on a property) style when used with isConstructorsRequiredPropertiesOnly() == true.
This pull-request adds support for the draft4 style ("requires" as an array of property names in object) when generating constructors with only required properties.
Thanks again for this great library.
Enjoy,
Jon