Check schema required array before is required flag

[newmen]

Hi,

The generated code is incorrect when a required field is an object, and it has required internal fields. It because of wrong algorithm checks is required flag of the field previously than tests a top defined required fields list. I've changed the checking order.

I mean the case where is the top schema follows:

{
  "$schema": "http://json-schema.org/draft-07/schema#",
  "type": ["object", "null"],
  "required": [
    "payment_type",
    "change_alignment",
    "billing_alignment"
  ],
  "properties": {
    "payment_type": {
      "type": "object",
      "$ref": "payment_type.json"
    },
    "change_alignment": {
      "type": "object",
      "$ref": "change_alignment.json"
    },
    "billing_alignment": {
      "type": "object",
      "$ref": "billing_alignment.json"
    }
  }
}

and billing_alignment.json is:

{
  "$schema": "http://json-schema.org/draft-07/schema#",
  "type": "object",
  "required": [
    "date_type"
  ],
  "properties": {
    "date_type": {
      "type": "string",
      "enum": [
        "activation",
        "anniversary"
      ]
    },
    "day": {
      "type": "integer",
      "minimum": 1,
      "maximum": 28
    }
  }
}

For this example, the wrong plugin with useOptionalForGetters=true generates Optional<BillingAlignment> type of getBillingAlignment method instead of just BillingAlignment.
I've fixed it and now the type is BillingAlignment.

[newmen]

You can change the checking order here if you feel the increasing performance here.
We can do that because hasFlag is returning boolean independently and if it returns false then we check the top required array. In the previous implementation, we did not check the top required array if the test of flag returned `false.

[newmen]

@joelittlejohn, when do you want to release 1.0.1?

[joelittlejohn]

It should be available on Maven Central now. Have a try.

…

On Mon, 1 Apr 2019, 14:55 Gleb Averchuk, ***@***.***> wrote: @joelittlejohn <https://github.com/joelittlejohn>, when do you want to release 1.0.1? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#964 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAp5MLEDhSzct4dZFxxY39v7Xu2Md359ks5vcg_ggaJpZM4cK10y> .

[newmen]

Awesome!