-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TypeError when running karma in singleRun:false and aggregating reporters #8
Comments
same here... |
After adding some debug info, I see the following flow:
|
@ben8p Thanks for the contribution! I'm trying to understand karma's lifecycle a bit better. Perhaps I am missing something or perhaps karma is a little inconsistent with itself: It appears this is the lifecycle of events for a karma reporter x = number of browsers
If watching / using TDD, I would expect that if I change a file, I would start over at What do you think? |
Well, |
@joeljeske will you consider merging the PR ? Do you need more inputs ? |
I am running into this issue as well. @joeljeske Can this PR be merged (assuming it fixes the issue) ? |
@abeymg maybe you can try the modified code locally and confirm it also fixes the issue you're having? |
@joeljeske @ben8p I did that and can confirm that it fixed the issue for me. |
Note: for support questions, please use stackoverflow. This repository's issues are reserved for feature requests and bug reports.
**I'm submitting a ... **
What is the current behavior?
If I run with singleRun:false and am aggregating a reporter, like junit or istaunbul; then on sequential runs I receive a TypeError.
It should not have this error. It should be able to run multiple times without failing.
To allow tdd while aggregating reporters.
The text was updated successfully, but these errors were encountered: