Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call through for global before-* and after-* blocks (fixes #64) #86

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ercultimate
Copy link

@ercultimate ercultimate commented Apr 28, 2023

  • Please check if the PR fulfills these requirements
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features) - none of the exiting or new tests explicitly verify things. I used the coverage report's execution count to verify.
  • Docs have been added / updated (for bug fixes / features) - no changes, the new behavior is what should be expected
  • What kind of change does this PR introduce?
    Bug fix

  • What is the current behavior?
    Global calls to the condition hooks are not executed on any shard.
    See Parallel throws away global beforeEach in multi-browser mode #64

  • What is the new behavior?
    The wrapper function will call through to the underlying library function for global calls to before/beforeAll, beforeEach, afterEach, and after/afterAll.

  • Does this PR introduce a breaking change?
    Unclear if in scope.

    • If the library consumer is using workarounds to run pre-/post-test logic and that logic is not idempotent, then they may see issues due to multiple executions of the pre-/post-test logic.
  • Other information:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant