Skip to content
This repository has been archived by the owner on Jun 16, 2020. It is now read-only.

Symbols fixup #1

Merged
merged 1 commit into from Oct 13, 2011
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 6 additions & 0 deletions lib/bitmask_attributes/value_proxy.rb
Expand Up @@ -13,6 +13,7 @@ def initialize(record, attribute, &extension)
# = OVERRIDE TO SERIALIZE =
# =========================

alias_method :orig_replace, :replace
%w(push << delete replace reject! select!).each do |override|
class_eval(<<-EOEVAL)
def #{override}(*args)
Expand All @@ -39,8 +40,13 @@ def validate!
end
end

def symbolize!
orig_replace(map(&:to_sym))
end

def updated!
validate!
symbolize!
uniq!
serialize!
end
Expand Down
3 changes: 3 additions & 0 deletions test/bitmask_attributes_test.rb
Expand Up @@ -34,7 +34,10 @@ class BitmaskAttributesTest < ActiveSupport::TestCase
assert_stored campaign, :web, :print, :phone
campaign.medium << :phone
assert_stored campaign, :web, :print, :phone
campaign.medium << "phone"
assert_stored campaign, :web, :print, :phone
assert_equal 1, campaign.medium.select { |value| value == :phone }.size
assert_equal 0, campaign.medium.select { |value| value == "phone" }.size
end

should "can assign new values at once to bitmask" do
Expand Down