Merge pull request #124 from joelnet/story/commit-hooks

add git hooks

package.json

@@ -28,6 +28,7 @@
     "eslint-plugin-fp": "^2.3.0",
     "eslint-plugin-prefer-arrow": "^1.1.2",
     "eslint-watch": "^4.0.2",
+    "husky": "^1.1.0",
     "jest": "^23.5.0",
     "sanctuary": "^0.15.0"
   },
@@ -38,6 +39,20 @@
     "collectCoverageFrom": [
       "**/*.{js,jsx,mjs}",
       "!coverage/**"
-    ]
+    ],
+    "coverageThreshold": {
+      "global": {
+        "statements": 100,
+        "branches": 100,
+        "functions": 100,
+        "lines": 100
+      }
+    }
+  },
+  "husky": {
+    "hooks": {
+      "pre-commit": "npm run test:coverage",
+      "pre-push": "npm run test:coverage"
+    }
   }
 }

types/__tests__/is.test.js

@@ -15,9 +15,15 @@ describe('types/is', () => {
       const actual = isBoolean(false)
       expect(actual).toBe(expected)
     })
+
+    test('null', () => {
+      const expected = false
+      const actual = isBoolean(null)
+      expect(actual).toBe(expected)
+    })
   })
 
-  describe('function', () => {
+  describe('Function', () => {
     const isFunction = is(Function)
 
     test('function', () => {
@@ -37,5 +43,113 @@ describe('types/is', () => {
       const actual = isFunction(jest.fn())
       expect(actual).toBe(expected)
     })
+
+    test('null', () => {
+      const expected = false
+      const actual = isFunction(null)
+      expect(actual).toBe(expected)
+    })
+  })
+
+  describe('Object', () => {
+    const isObject = is(Object)
+
+    test('Object', () => {
+      const expected = true
+      const actual = isObject({})
+      expect(actual).toBe(expected)
+    })
+
+    test('new Object', () => {
+      const expected = true
+      const actual = isObject(new Object())
+      expect(actual).toBe(expected)
+    })
+
+    test('null', () => {
+      const expected = false
+      const actual = isObject(null)
+      expect(actual).toBe(expected)
+    })
+  })
+
+  describe('String', () => {
+    const isString = is(String)
+
+    test('String', () => {
+      const expected = true
+      const actual = isString('abc')
+      expect(actual).toBe(expected)
+    })
+
+    test('empty String', () => {
+      const expected = true
+      const actual = isString('')
+      expect(actual).toBe(expected)
+    })
+
+    test('null', () => {
+      const expected = false
+      const actual = isString(null)
+      expect(actual).toBe(expected)
+    })
+  })
+
+  describe('Array', () => {
+    const isArray = is(Array)
+
+    test('Array', () => {
+      const expected = true
+      const actual = isArray([1, 2, 3])
+      expect(actual).toBe(expected)
+    })
+
+    test('empty Array', () => {
+      const expected = true
+      const actual = isArray([])
+      expect(actual).toBe(expected)
+    })
+
+    test('new Array', () => {
+      const expected = true
+      const actual = isArray(new Array())
+      expect(actual).toBe(expected)
+    })
+
+    test('null', () => {
+      const expected = false
+      const actual = isArray(null)
+      expect(actual).toBe(expected)
+    })
+  })
+
+  describe('Promise', () => {
+    const isPromise = is(Promise)
+
+    test('Promise.resolve()', () => {
+      const expected = true
+      const actual = isPromise(Promise.resolve())
+      expect(actual).toBe(expected)
+    })
+
+    test('Promise.reject()', () => {
+      const expected = true
+      const reject = Promise.reject()
+      const actual = isPromise(reject)
+      reject.catch(() => {}) // silence test errors
+      expect(actual).toBe(expected)
+    })
+
+    test('thenable', () => {
+      const expected = true
+      const actual = isPromise({ then: resolve => resolve() })
+      expect(actual).toBe(expected)
+    })
+
+    test('null', () => {
+      const expected = false
+      const actual = isPromise(null)
+      expect(actual).toBe(expected)
+    })
   })
 })

types/is.js

@@ -1,7 +1,7 @@
 /* eslint-disable */
 const is = ctor => value =>
-  ctor === Function
-    ? typeof value === 'function'
-    : value != null && value.constructor === ctor || value instanceof ctor
+  ctor === Function ? typeof value === 'function'
+  : value != null && is (Function) (value.then) ? true
+  : value != null && value.constructor === ctor || value instanceof ctor
 
 module.exports = is