Skip to content

Commit

Permalink
Switch to full tab options
Browse files Browse the repository at this point in the history
- Google Chrome 74 seems to have an issue with Talkie's options page.
- The options page itself works fine, but displaying it in Chrome's extension details page for Talkie does not work. Nothing displayed, no error message.
- The recommended options page style is (was?) to use the predefined in-browser options page. It seems this no longer works for Talkie.
- This commit changes options ui settings to instead use a full tab for the options.
- Further user interface changes are needed to make this pretty, as the previous version relied on the browser's extension branding the options.
  • Loading branch information
joelpurra committed May 3, 2019
1 parent 5928d5e commit 0358241
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion manifest.json
Expand Up @@ -73,7 +73,9 @@
},
"options_ui": {
"page": "./src/options/options.html",
"chrome_style": true
"chrome_style": false,
"browser_style": false,
"open_in_tab": true
},
"requirements": {},
"offline_enabled": true,
Expand Down

0 comments on commit 0358241

Please sign in to comment.