Improve missing translation message debugging details

joelpurra · Dec 29, 2021 · bef88ff · bef88ff
1 parent f1305ad
commit bef88ff
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/code/packages/shared-locales/package.json b/code/packages/shared-locales/package.json
@@ -25,7 +25,7 @@
     "clean": "rimraf ./dist && npm run --silent clean:locales",
     "clean:locales": "( cd ./src/data/_locales/ && rimraf ./*/messages.json ; ) && rimraf ./src/data/languages/extracted.json ./src/data/languages/languages.json",
     "languages:refresh": "( cd ./src/data/_locales/ && jq --slurp --sort-keys 'map({ (.extensionLocale.message): { direction: .extensionLocaleBidiDirection.message, sample: .frontend_voicesSampleText.message } }) | add' $(find . -name 'messages.json') > \"../languages/extracted.json~\" ; ) && mv \"./src/data/languages/extracted.json~\" \"./src/data/languages/extracted.json\" && jq --slurp --sort-keys '{ base: .[0], languages: .[1] } + .[3]' \"./src/data/languages/base.json\" \"./src/data/languages/extracted.json\" \"./src/data/languages/overrides.json\" > \"./src/data/languages/languages.json~\" && mv \"./src/data/languages/languages.json~\" \"./src/data/languages/languages.json\"",
-    "messages:count": "( cd ./src/data/_locales/ && for MESSAGES in $(find . -name 'messages.json'); do jq 'to_entries | .[].key' \"$MESSAGES\"; done | sort | uniq -c ; )",
+    "messages:count": "( cd ./src/data/_locales/ && for MESSAGES in $(find . -name 'messages.json'); do jq 'to_entries | .[].key' \"$MESSAGES\"; done | sort | uniq -c | sort -n -r ; )",
     "messages:download": "npm run --silent messages:sort && webext-translator . en base.json automatic.json && npm run --silent messages:sort",
     "messages:override:refresh": "( cd ./src/data/_locales/ && for MESSAGES in $(find . \\( -name 'override.json' -or -name 'manual.json' \\)); do jq --slurp --sort-keys '.[0] as $en | .[1] | with_entries(.key as $key | .value |= (.original = $en[$key].message) + if $en[$key].description then { description: $en[$key].description } else {} end + if $en[$key].placeholders then { placeholders: $en[$key].placeholders } else {} end)' \"./en/messages.json\" \"$MESSAGES\" > \"${MESSAGES}~\"; mv \"${MESSAGES}~\" \"$MESSAGES\"; done ; )",
     "messages:refresh": "[ ! -f ./src/data/_locales/en/messages.json ] && npm run --silent messages:sort && ./src/translation-merge.sh && npm run --silent messages:sort && npm run --silent messages:override:refresh",

diff --git a/code/packages/split-environment-node/src/translator-provider.mts b/code/packages/split-environment-node/src/translator-provider.mts
@@ -142,7 +142,7 @@ export default class NodeEnvironmentTranslatorProvider implements ITranslatorPro
 							const extrasIndex = Number.parseInt(placeholder.content.replace("$", ""), 10) - 1;
 
 							if (Number.isNaN(extrasIndex) || extrasIndex < 0 || extrasIndex >= extras.length) {
-								throw new RangeError(`Variable lookup extras index out of range: ${extrasIndex}`);
+								throw new RangeError(`Variable lookup extras index out of range (${extrasIndex}) for ${JSON.stringify(placeholderName)} in ${JSON.stringify(placeholder)} of ${JSON.stringify(messageTemplate)} with key ${JSON.stringify(key)}.`);
 							}
 
 							const extra = extras[extrasIndex];