Skip to content

Commit

Permalink
Remove delay effect...
Browse files Browse the repository at this point in the history
There are some subtleties around composing a delay with color effects,
so we decided to just remove it and let people code their own delays.
References #50.
  • Loading branch information
Brenton Ashworth and Craig Andera committed Jan 9, 2012
1 parent 3a7bdfe commit 7076be5
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 5 deletions.
4 changes: 2 additions & 2 deletions src/app/cljs/one/sample/animation.cljs
Expand Up @@ -79,7 +79,7 @@
[]
(start (parallel (bind form {:effect :fade :start 1 :end 0 :time 500})
(bind cloud
{:effect :delay :time 500}
{:effect :color :time 500} ; Dummy animation for delay purposes
{:effect :fade-in-and-show :time 600}))))

(defn show-form
Expand All @@ -88,7 +88,7 @@
[]
(start (serial (parallel (bind cloud {:effect :fade-out-and-hide :time 500})
(bind form
{:effect :delay :time 300}
{:effect :color :time 300} ; Dummy animation for delay purposes
form-in))
(bind label fade-in move-down))))

Expand Down
3 changes: 0 additions & 3 deletions src/lib/cljs/one/browser/animation.cljs
Expand Up @@ -204,9 +204,6 @@
time
accel)))

(defmethod standardize :delay [element m]
(standardize element {:effect :color :time (:time m)}))

(comment ;; Color effect examples

(def label (get-element "//label[@id='name-input-label']/span"))
Expand Down

0 comments on commit 7076be5

Please sign in to comment.