Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search score refactor #858

Merged
merged 2 commits into from Apr 6, 2023
Merged

Conversation

kaspth
Copy link
Contributor

@kaspth kaspth commented Apr 6, 2023

Also adds a score_for method to extract scores for individual attributes then.

A version discussed in https://gist.github.com/kaspth/54c2541309704e054bca2be5ace3ebee

Pull request checklist

  • My code contains tests covering the code I modified
  • I linted and tested the project with bin/check
  • I added significant changes and product updates to the changelog

Also adds a `score_for` method to extract scores for individual attributes then.
@joemasilotti joemasilotti merged commit 7b15776 into joemasilotti:search-score Apr 6, 2023
1 check failed
@joemasilotti
Copy link
Owner

Thanks for this @kaspth!

@kaspth kaspth deleted the search-score branch April 7, 2023 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants