remove colon from pair "user:pass" if has no password

(closes github issue libwww-perl#13)
joenio · Jan 24, 2016 · fa47826 · fa47826
1 parent c6b1466
commit fa47826
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 2 deletions.
diff --git a/lib/URI/_userpass.pm b/lib/URI/_userpass.pm
@@ -40,8 +40,8 @@ sub password
 	my $user = defined($info) ? $info : "";
 	$user =~ s/:.*//;
 
-	if (!defined($new) && !length($user)) {
-	    $self->userinfo(undef);
+	if (!defined($new)) {
+	    $self->userinfo($user || undef);
 	} else {
 	    $new = "" unless defined($new);
 	    $new =~ s/%/%25/g;

diff --git a/t/userpass.t b/t/userpass.t
@@ -0,0 +1,12 @@
+use strict;
+use warnings;
+
+print "1..1\n";
+
+use URI;
+
+my $uri = URI->new("rsync://foo:bar\@example.com");
+$uri->password(undef);
+
+print "not " if $uri->as_string =~ /foo:\@example.com/;
+print "ok 1\n";