Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTML renderer: show session name in header #260

Merged
merged 6 commits into from
Aug 21, 2023

Conversation

matthiasdiener
Copy link
Contributor

@matthiasdiener matthiasdiener commented Aug 7, 2023

The session name is currently only shown in the tab title, as far as I can see. The tab title is often cut off, and can't be easily copied.

Here is how it looks like:

image

@joerick
Copy link
Owner

joerick commented Aug 12, 2023

this screenshot doesn't look good, it breaks the layout.

perhaps something like this would work better?

Desktop Copy

@joerick
Copy link
Owner

joerick commented Aug 12, 2023

font settings for this are-

image

@matthiasdiener
Copy link
Contributor Author

this screenshot doesn't look good, it breaks the layout.

perhaps something like this would work better?

Desktop Copy

This looks great! Do you have a patch already that shows the session like that, or would you like me to go ahead and create one?

@joerick
Copy link
Owner

joerick commented Aug 18, 2023

i don't this was just something I mocked up in Sketch a while ago

@joerick
Copy link
Owner

joerick commented Aug 18, 2023

so if you're interested in making a patch for this, please do!

@matthiasdiener
Copy link
Contributor Author

matthiasdiener commented Aug 18, 2023

Here is what I came up with:

image

@joerick
Copy link
Owner

joerick commented Aug 21, 2023

Cheers @matthiasdiener, I just tweaked it a bit to put the code in App.svelte, I prefer to keep the 'header' component just rendering the header block.

@joerick joerick merged commit c227d4e into joerick:main Aug 21, 2023
21 checks passed
@matthiasdiener matthiasdiener deleted the html-show-name branch August 21, 2023 13:41
@matthiasdiener
Copy link
Contributor Author

Thanks @joerick ! Is there any chance for a new release? The changes in this PR and in #258 have been very useful!

@joerick
Copy link
Owner

joerick commented Aug 21, 2023

yes, I will do soon, I have been working on 3.12 support but just merged that so I'll do a release very soon. Thanks for the ping :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants