Bug about REACHING_DEF

[clccc]

I test the newest joern v1.0.186. I found that some reaching-def edges did not labeld VARIABLE. A reaching-def edge should have an associate def-variable, is it right?

[clccc]

Some nodes of inE("REACHING_DEF").outV does not really define the inV directly. The 3rd argument "left" does not defined by "pms->buf", "p", "zbx_md5_append(***)", but there are reaching-def edges between them. And the right defined node should be "left-=64" is not the Identifier "left". 

[fabsx00]

Some of the labels are missing, I'll add those some time this week. When it comes to additional edges: the PDG is now highly overtainted on purpose, a step which I'll need to explain in an article soon. I think it's a good idea though to provide a nice little PDG extraction API that covers this up. This is coming in this week. That should also solve for #342

[clccc]

Great, I am looking forward to your article.

[fabsx00]

@clccc the missing edge labels on data flow edges should be fixed once #346 is merged.

[fabsx00]

ShiftLeftSecurity/codepropertygraph#963

[fabsx00]

See ShiftLeftSecurity/codepropertygraph#955 - this is fixed now, but you'll need to use dotDdg instead of reading the raw edges. I also created run.dumpDdg for dumping of the DDG to disk: ShiftLeftSecurity/codepropertygraph#973

[clccc]

I test the fixed joern，the result showed below.

I don't know why some reaching-def edges have a " " as VARIABLE. I find this problem persistent alwarys. Is it on purpose? Sorry, I can't understand its reasonableness.