trim querydb dependencies: fix testDistro.sh #2757
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Querydb shipped a number of frontends in it's regular classpath, which
is causing problems with the usual suspects log4j/slf4j (see error below).
The main culprit is probably ghidra which ships an older version of log4j
in a fat jar.
```
Loading base CPG from:
/home/mp/Projects/shiftleft/joern/workspace/c/cpg.bin.tmp
java.lang.NoSuchMethodError: 'java.lang.ClassLoader[]
org.apache.logging.log4j.util.LoaderUtil.getClassLoaders()'
at
org.apache.logging.log4j.core.impl.ThreadContextDataInjector.getServiceProviders(ThreadContextDataInjector.java:83)
at
org.apache.logging.log4j.core.impl.ThreadContextDataInjector.initServiceProviders(ThreadContextDataInjector.java:73)
at
org.apache.logging.log4j.core.impl.ThreadContextDataInjector.getProviders(ThreadContextDataInjector.java:285)
```
ursachec
approved these changes
May 23, 2023
|
@ursachec querydb uses some runtime reflection iirc, could that be a problem here? |
|
would like to be more helpful, but the only answer i have is "not sure" @mpollmeier |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Querydb shipped a number of frontends in it's regular classpath, which
is causing problems with the usual suspects log4j/slf4j (see error below).
The main culprit is probably ghidra which ships an older version of log4j
in a fat jar.