remove traversal, attempt 3 #2784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbrehm
requested review from
fabsx00,
mpollmeier,
ml86,
itsacoderepo and
DavidBakerEffendi
mpollmeier
reviewed
May 31, 2023
Co-authored-by: Michael Pollmeier <michael@michaelpollmeier.com>
Co-authored-by: Michael Pollmeier <michael@michaelpollmeier.com>
Co-authored-by: Michael Pollmeier <michael@michaelpollmeier.com>
Co-authored-by: Michael Pollmeier <michael@michaelpollmeier.com>
Co-authored-by: Michael Pollmeier <michael@michaelpollmeier.com>
Co-authored-by: Michael Pollmeier <michael@michaelpollmeier.com>
Co-authored-by: Michael Pollmeier <michael@michaelpollmeier.com>
Co-authored-by: Michael Pollmeier <michael@michaelpollmeier.com>
DavidBakerEffendi
added
the
infrastructure
mpollmeier
approved these changes
Jun 1, 2023
|
I can handle the 2.0.0 version bump |
This was referenced Jun 1, 2023
|
Ready to merge. @mpollmeier -- can you make this version 2.0.0 to signify the break? Or version 1.2.0 ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The third attempt at removing Traversal, this time with a detailed migration guide in a new changelog. Please do read the
News.mdfile. The thing may be too verbose?This PR is WIP in the sense that its upstream is not in yet -- I think we first need to review how happy we are with the documentation and the amount of breakage (we might want to change some upstream things to further improve compat here?).