Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reintroduce Python Compatibility Changes #2785

Merged
merged 3 commits into from
Jun 2, 2023
Merged

Reintroduce Python Compatibility Changes #2785

merged 3 commits into from
Jun 2, 2023

Conversation

DavidBakerEffendi
Copy link
Collaborator

  • Reverted commit 4691b4a
  • Added tests that were resulting in some failure
  • Added support for string constant type hints (idk how but this is valid Python)
  • Using ForkJoinParallelCpgPass for DynamicTypeHintFullNamePass
  • Making sure that DynamicTypeHintFullNamePass considers types within the current scope

@DavidBakerEffendi DavidBakerEffendi marked this pull request as ready for review May 31, 2023 13:34
@DavidBakerEffendi DavidBakerEffendi added python Relates to pysrc2cpg performance Improves the performance of Joern compatibility Concerns fixing either upstream or downstream compatibility labels May 31, 2023
@DavidBakerEffendi DavidBakerEffendi mentioned this pull request May 31, 2023
Open
@ml86
Copy link
Contributor

ml86 commented Jun 1, 2023

Is this the minimally adjusted version of commit 4691b4a to make the type propagation happy? Do we need the switch to ForkJoinParallelCpgPass in this PR? I am asking because i would like to diff this PR and my initial version of it.

@DavidBakerEffendi
Copy link
Collaborator Author

@ml86 Wouldn't say "minimally" but it does fix some assumptions on the type propagation to make it "happier". The ForkJoinParallelCpgPass is not necessary, but the other changes on DynamicTypeHintFullNamePass are necessary.

@DavidBakerEffendi
Make pysrc2cpg compatible with closed source data flow tracker again. (…
347a9f3 
…#2680)
@DavidBakerEffendi
ossdataflowengine: fix edge case when tracking from receivers (#2722)
a60270b
@DavidBakerEffendi
Type Recovery Tweaks
a662a4f 
* Added tests that were resulting in some failure
* Added support for string constant type hints (idk how but this is valid Python)
* Using `ForkJoinParallelCpgPass` for `DynamicTypeHintFullNamePass`
* Making sure that `DynamicTypeHintFullNamePass` considers types within the current scope
* Sharing the logic for import path resolution between `XInheritanceFullNamePass` and `DynamicTypeHintFullNamePass`
ml86
ml86 approved these changes Jun 2, 2023
View reviewed changes
Copy link
Contributor

@ml86 ml86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good. Tests pass.

@DavidBakerEffendi DavidBakerEffendi merged commit af9761d into master Jun 2, 2023
5 checks passed
@DavidBakerEffendi DavidBakerEffendi deleted the dave/py-revert-back-pychanges branch June 2, 2023 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ml86 ml86 ml86 approved these changes

@fabsx00 fabsx00 Awaiting requested review from fabsx00

Assignees
No one assigned
Labels
compatibility Concerns fixing either upstream or downstream compatibility performance Improves the performance of Joern python Relates to pysrc2cpg
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@DavidBakerEffendi @ml86