Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make flows via statically dispatched methods work #2810

Merged
merged 2 commits into from
Jun 5, 2023
Merged

Conversation

fabsx00
Copy link
Contributor

@fabsx00 fabsx00 commented Jun 5, 2023

Right now, all call nodes in RUBY have dispatch-type "STATIC", however, prior to this commit, METHOD and corresponding CALL nodes did not have matching full names, which meant that call linking failed. This PR fixes that.

Follow-up work is required to handle dynamically dispatched calls in combination with the type propagator.

@fabsx00 fabsx00 merged commit daa68e3 into master Jun 5, 2023
5 checks passed
@max-leuthaeuser max-leuthaeuser deleted the fabs/rubyflow branch July 18, 2023 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants