Make the filename property in pysrc2cpg relative again. #3544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This the introduction of META_DATA.root, absolute path are not longer required.
DavidBakerEffendi
approved these changes
Aug 24, 2023
| @@ -459,7 +459,7 @@ class TypeRecoveryPassTests extends PySrc2CpgFixture(withOssDataflow = false) { | |||
|
|
|||
| "correctly determine that, despite being unable to resolve the correct method full name, that it is an internal method" in { | |||
| val Some(selfFindFound) = cpg.typeDecl(".*InstallationsDAO.*").ast.isCall.name("find_one").headOption: @unchecked | |||
| selfFindFound.callee.isExternal.toSeq shouldBe Seq(true, false) | |||
| selfFindFound.callee.isExternal.toSeq shouldBe Seq(true, true) | |||
There was a problem hiding this comment.
This contradicts the description of the test case, though I wonder what the cause of this is - perhaps import resolution is confused.
|
I think go ahead with the merge and I'll make a separate PR to look into the type recovery part |
DavidBakerEffendi
added a commit
that referenced
this pull request
Aug 28, 2023
As a follow up on this PR #3544 I investigated the claim of the unresolved method being intended as labelled isExternal=false. I think it's likely a dangerous assumption to have in the first place with a path that has as many dummy access paths as the test had. I'm happy to keep the expectation to be isExternal=true.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This the introduction of META_DATA.root, absolute path are not longer
required.
@DavidBakerEffendi can you please have a special look on the expectation i change in joern-cli/frontends/pysrc2cpg/src/test/scala/io/joern/pysrc2cpg/passes/TypeRecoveryPassTests.scala
To me it looks like it has been wrong in the first place because
find_oneshould be external.