[dataflowengineoss] revert DdgGenerator usage of globalFromLiteral
#4582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xavierpinho
added
bug
DavidBakerEffendi
approved these changes
May 21, 2024
karan-batavia
pushed a commit
to Privado-Inc/joern
that referenced
this pull request
Jun 18, 2024
…oernio#4582) * [dataflowengineoss] DdgGenerator using original globalFromLiteral's implementation * simplify some tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up on #4576:
globalFromLiteralto the implementation that fixed [python] incoherent flow when using a literal vs identifier argument #4549DdgGeneratoruse the original (before 4549)globalFromLiteralimplementation, inlined.The issue in 4549 is that
globalFromLiteralwas being overly inclusive when computing the starting points forreachableBy. Having fixed that, we noticed missing flows afterward. The trouble is thatglobalFromLiteralis also being used byDdgGenerator. So, a quick fix is to haveDdgGeneratoruse the originalglobalFromLiteralwhile keepingreachableByuse the updated version.