[jssrc2cpg] Overhaul typedecl method bindings #4727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
max-leuthaeuser
changed the title
max-leuthaeuser
commented
Jul 4, 2024
| @@ -324,308 +323,6 @@ class TsDecoratorAstCreationPassTests extends AstJsSrc2CpgSuite(".ts") { | |||
| annotationD.parameterAssign.l shouldBe empty | |||
| } | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
This was code duplicated in TsAstCreationPassTests.scala
maltek
approved these changes
Jul 5, 2024
| inside(cpg.typeDecl("Greeter").member.l) { case List(init, greeting, name, propName, foo, anon, toString) => | ||
| init.name shouldBe "<init>" | ||
| init.typeFullName shouldBe "Test0.ts::program:Greeter" | ||
| init.dynamicTypeHintFullName shouldBe List("Test0.ts::program:Greeter:<init>") |
There was a problem hiding this comment.
like we discussed, this isn't entirely correct but not a blocker
max-leuthaeuser
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.