Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add alreadyInitialized option which skips piwik initialization #42

Closed

Conversation

swergas
Copy link

@swergas swergas commented Aug 17, 2017

Naive fix for #41

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 55a93a2 on assembl:skip_piwik_initialization into 999fe4b on joernroeder:master.

@sapegin
Copy link

sapegin commented Nov 14, 2017

@swergas @joernroeder How can I help to get this merged? Have a similar issue.

joernroeder added a commit that referenced this pull request Nov 15, 2017
@joernroeder
Copy link
Owner

joernroeder commented Nov 15, 2017

@swergas @sapegin

i've looked at this today and propose another pull request which introduces a dynamic "already initialized" check #46 .
would you mind to pull down the feature branch and give it a try?

@joernroeder
Copy link
Owner

joernroeder commented Nov 15, 2017

@swergas thanks for contributing! I'm going to close this request for now as #46 builds on top of it.
feel free to reopen this thread :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants