check CanInterface before calling Interface

joeshaw · Jan 29, 2018 · a0ce5e6 · a0ce5e6
1 parent ce5db18
commit a0ce5e6
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 0 deletions.
diff --git a/envdecode.go b/envdecode.go
@@ -118,6 +118,10 @@ func decode(target interface{}, strict bool) (int, error) {
 			fallthrough
 
 		case reflect.Struct:
+			if !f.Addr().CanInterface() {
+				continue
+			}
+
 			ss := f.Addr().Interface()
 			_, custom := ss.(Decoder)
 			if custom {

diff --git a/envdecode_test.go b/envdecode_test.go
@@ -9,6 +9,7 @@ import (
 	"reflect"
 	"sort"
 	"strconv"
+	"sync"
 	"testing"
 	"time"
 )
@@ -59,6 +60,8 @@ type testConfig struct {
 	DefaultSliceInt []int         `env:"TEST_UNSET,asdf=asdf,default=1;2;3"`
 	DefaultDuration time.Duration `env:"TEST_UNSET,asdf=asdf,default=24h"`
 	DefaultURL      *url.URL      `env:"TEST_UNSET,default=http://example.com"`
+
+	cantInterfaceField sync.Mutex
 }
 
 type testConfigNoSet struct {