Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lowercase scheme and authority per specification. #183

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from

Conversation

joestump
Copy link
Owner

@joestump joestump commented Aug 2, 2015

Closes #29. More robustly follows URL normalization per the specification now. See #133 for additional and related discussion.

@joestump
Copy link
Owner Author

joestump commented Aug 2, 2015

@jaitaiwan I'm not sure what's going on, but it appears PT3K support never passed tests? Or isn't merged into develop? Not really sure; everything says up to date with master/develope locally.

@jaitaiwan
Copy link
Contributor

We never ended up merging any py3k support into develop at all because mine was too incomplete. I don't know how it passed tests originally but it's not working now. I think the vote was on using tseaver's py3k branch and fixing the 2 tests that didn't pass.

@joestump
Copy link
Owner Author

joestump commented Aug 2, 2015

Somehow .travis.yml is running PT3K tests. No idea why because it's not in this branch?

@joestump
Copy link
Owner Author

joestump commented Aug 2, 2015

@jaitaiwan looks like you pushed PT3K builds to develop in c3d8b72. Can you back that out and move that over to the PT3K branch until it's merged in so we can merge this for 1.9RC1?

@jaitaiwan
Copy link
Contributor

Sure not a problem.

@jaitaiwan
Copy link
Contributor

@joestump change has been completed and RC1 has been tagged in a release/1.9 branch :)

@joestump
Copy link
Owner Author

joestump commented Aug 2, 2015

Tests are passing. This is ready for a final review. 👍

@TimSC
Copy link
Contributor

TimSC commented Jan 13, 2018

I pulled this PR into a new fork: https://github.com/TimSC/python-oauth10a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants