Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding RSA SignatureMethod and test #38

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rick446
Copy link

@rick446 rick446 commented Dec 1, 2010

That's pretty much it. Uses PyCrypto if it's installed, raises NotImplementedError otherwise.

@rick446
Copy link
Author

rick446 commented Dec 2, 2010

I guess I should also mention that the patch includes unit testing

@zookos
Copy link
Contributor

zookos commented Feb 1, 2011

Hi @rick446! Thanks for the patch. It looks good and I'm glad to see it comes with a test. Two requests:

  1. Could you add a test to ensure that verify() doesn't accept the request when it comes with a bogus signatures that wasn't actually made by the private key?
  2. Could you add a test that the signature produced by your code matches the example signature from http://wiki.oauth.net/w/page/12238556/TestCases . (If it helps you could also use these other implementations to check signatures or to generate example signatures: https://github.com/nshah/python-oauth/blob/master/oauth/signature_method/rsa_sha1.py , http://code.google.com/p/gdata-python-client/source/browse/src/gdata/oauth/rsa.py .)

Thanks again!

Regards,

Zooko

@gorakhargosh
Copy link

I have implemented this atop PyCrypto using X.509 certificates/public
keys and RSA private keys in my Python implementation of OAuth 1.0.
The tests you have mentioned pass.

See: https://github.com/gorakhargosh/pyoauth/blob/master/pyoauth/protocol.py#L189

The project is at http://github.com/gorakhargosh/pyoauth/

HTH.

Cheers!
Khargosh.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants