update to Intermediate labels #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks great. Thanks for updating the builder too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing code for showing intermediate labels is locked to the left side axis and using scientific representation. The suggested code defaults to use the same axis and formatting as the max/min labels, depending on direction, and with an option to allow the intermediate labels to not be on the same axis. As well as a dedicated formatting function like the max/min labels to allow custom formatting if desired.
After realizing the previous code probably was being used with backwards scrolling i guess the option to move the labels to the other axis may not be very usefull, but the defaults provide uniformity now.
Also added the options to the builder to allow users to play with them.
Suggestions are most welcome.