Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Connection: == "Upgrade" assumes no other parameters #5

Closed
Lerc opened this issue May 9, 2013 · 1 comment
Closed

Connection: == "Upgrade" assumes no other parameters #5

Lerc opened this issue May 9, 2013 · 1 comment

Comments

@Lerc
Copy link

Lerc commented May 9, 2013

Firefox sends

Connection: keep-alive, Upgrade

in http.go

if strings.ToLower(hdrs.Get("Upgrade")) == "websocket" && strings.ToLower(hdrs.Get("Connection")) == "upgrade" {
@joewalnes joewalnes mentioned this issue Dec 10, 2013
Closed
@cokeeffekt
Copy link

remove, && strings.ToLower(hdrs.Get("Connection")) == "upgrade".... horribly simple fix. i really dont know what im doing with go, but it worked.

joewalnes added a commit that referenced this issue Dec 19, 2013
@joewalnes
Merge pull request #22 from thypon/master
72de577 
Fix issue #5,#6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@joewalnes @Lerc @cokeeffekt