Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for get_marriages and get_name #8

Merged
merged 6 commits into from
Nov 27, 2018
Merged

Fix for get_marriages and get_name #8

merged 6 commits into from
Nov 27, 2018

Conversation

damonbrodie
Copy link

@damonbrodie damonbrodie commented Nov 22, 2018 •
edited by joeyaurel
Loading

get_marriages was being assembled improperly. I ran this against my gedcom and it works properly, but it could use a decent code review and some more testing.

Issue: #9

@damonbrodie damonbrodie mentioned this pull request Nov 27, 2018
Closed
@joeyaurel joeyaurel self-assigned this Nov 27, 2018
@joeyaurel joeyaurel added the bug Something isn't working label Nov 27, 2018
@joeyaurel joeyaurel added this to To do in Python GEDCOM Parser via automation Nov 27, 2018
@joeyaurel joeyaurel added this to the v1.0.0 milestone Nov 27, 2018
joeyaurel
joeyaurel requested changes Nov 27, 2018
View reviewed changes
Copy link
Owner

@joeyaurel joeyaurel left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nomadyow Looks fine to me, but some little changes should be made :) And would you also update the version string in the setup.py?

README.md Outdated Show resolved Hide resolved
gedcom/__init__.py Outdated Show resolved Hide resolved
@joeyaurel joeyaurel merged commit 80846b5 into joeyaurel:develop Nov 27, 2018
Python GEDCOM Parser automation moved this from To do to Done Nov 27, 2018
@joeyaurel
Copy link
Owner

@nomadyow Thank you!

damonbrodie referenced this pull request in damonbrodie/python-gedcom Nov 27, 2018
@damonbrodie
Merge pull request #3 from nickreynke/develop
849ce89 
Merge pull request #8 from nomadyow/develop
@joeyaurel joeyaurel changed the title Fix for get_marriages Fix for get_marriages and get_name Nov 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joeyaurel joeyaurel joeyaurel approved these changes

Assignees

@joeyaurel joeyaurel

Labels
bug Something isn't working
Projects
Python GEDCOM Parser
  
Done
Milestone
v1.0.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@damonbrodie @joeyaurel