Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify 403 API "rate limit exceeded" errors in the application #48

Closed
joeyespo opened this issue Feb 4, 2014 · 4 comments
Closed

Clarify 403 API "rate limit exceeded" errors in the application #48

joeyespo opened this issue Feb 4, 2014 · 4 comments

Comments

@joeyespo
Copy link
Owner

joeyespo commented Feb 4, 2014

This has come up several times (e.g. #15, #18, #45) and causes people to come here looking for answers.

Instead, Grip should handle this error inside the application. It can either provide instructions on how to run using --user / --pass or even better, a login form to accept the credentials without requiring a restart.

@sjackman
Copy link

👍

@sjackman
Copy link

I'm running grip --export from the command line, and the result is an HTML file composed of 403 Forbidden. Could a ~/.grip.conf file contain the username and GitHub API token?

@joeyespo joeyespo changed the title Handle 403 API rate limit exceeded errors in the application Be clear about 403 API "rate limit exceeded" errors in the application Jun 14, 2014
@joeyespo joeyespo changed the title Be clear about 403 API "rate limit exceeded" errors in the application Clarify 403 API "rate limit exceeded" errors in the application Jun 14, 2014
@joeyespo
Copy link
Owner Author

@sjackman That's a good idea. Any chance you could open a separate issue for it?

@joeyespo
Copy link
Owner Author

Fixed with 88fcc3f.

Here's a screenshot of when you hit the rate limit with this change.

rate-limit

And here's a screenshot of when you hit the limit while using auth. There's less text because you'll probably only use auth after hitting the rate limit the first time.

extended-rate-limit

These can be viewed and tested locally by visiting localhost/rate-limit-preview and localhost/rate-limit-preview?auth=1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants