Stop browser opening consuming all the sockets

[markbt]

The sense of the test in is_server_running is inverted.

This means wait_for_server races with the server starting:

• If the server starts first, wait_for_server will never return, and will quickly consume all available ephemeral ports on the system.
• If the server doesn't start first, wait_for_server returns immediately and the browser opens to a blank page.

This fix:

• Fixes the sense of the test, and makes the code more explicit
• Adds a delay in wait_for_server so that ephemeral sockets aren't rapidly consumed while we wait for it to start.

[joeyespo]

Beat me to it. Glad to see you came to the same conclusion with the logic inversion and adding a sleep delay.

I was also wondering if adding sock.close() was necessary here if rc == 0. I was still seeing some strange behavior, however I usually run Grip with Werkzeug's debug=True, so that might be causing some other side effects with this. Have any thoughts about sock.close()?

Thanks for the fix, @markbt!

[markbt]

The socket should get closed when sock goes out of scope and gets garbage collected. It certainly couldn't do any harm, though.