Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tries collection twice when aborted during it #52

Closed
blueyed opened this issue Apr 7, 2016 · 2 comments · Fixed by michaeljoseph/mould#12
Closed

Tries collection twice when aborted during it #52

blueyed opened this issue Apr 7, 2016 · 2 comments · Fixed by michaeljoseph/mould#12
Labels
bug

Comments

@blueyed
Copy link
Collaborator

blueyed commented Apr 7, 2016

When aborting ptw in the collection phase it will not quit, but retry it:

% ptw ...
^CError: Could not run --collect-only to find the pytest config file. Trying again without silencing stdout..

I think it should exit on SIGINT here.
@joeyespo
Copy link
Owner

joeyespo commented Apr 8, 2016

Ooh, nice find! Looks like KeyboardInterrupt was never handled in the new config collecting code.

Fixing soon.

joeyespo added a commit that referenced this issue Apr 8, 2016
@joeyespo
Fix #52 by handlingKeyboardInterrupt during inifile collection.
00a29bc
@joeyespo joeyespo mentioned this issue Apr 8, 2016
Merged
@joeyespo joeyespo added the bug label Apr 8, 2016
@joeyespo
Copy link
Owner

joeyespo commented Apr 8, 2016

Just published v4.1.0 with this fix. Thanks, @blueyed!

@pyup-bot pyup-bot mentioned this issue Aug 17, 2016
Closed
@pyup-bot pyup-bot mentioned this issue Jul 24, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Pin pytest-watch to latest version 4.1.0 michaeljoseph/mould
pin poncki/pydd
2 participants
@blueyed @joeyespo