Added loading options from pytest.ini #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Things Added: 1. CollectIniPathPlugin which acts as a pytest plugin and does a dry-run of pytest to capture the ini path in CollectorIniPath.pytest_ini_path class variable 2. Load "pytest-watch" section from that ini and read the options 3. Mix that option with cmdline args, giving preference to cmdline values Todo: 1. Add proper tests for ini args loading 2. Refactor string and boolean variable loading code to diff. func, whole thing looks bad now
|
PR for issue #20 |
|
Should I move the ini path collector to a new module, does it look a bit out of place in command.py? |
|
Does it look ok, @joeyespo ? |
|
Looks good. Ready to merge? |
|
Yes. |
|
👍 Thanks, @bendtherules! |
joeyespo
added a commit
that referenced
this pull request
Dec 4, 2015
Added loading options from pytest.ini
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Things Added:
Todo:
Refactor string and boolean variable loading code to diff. func, whole thing looks bad now