#136: Refactoring deprecated find_element_by_* and find_elements_by_* #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sossnowski
approved these changes
Feb 20, 2023
|
Can you resolve the conflicts? I'll merge it in after it's resolved |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Methods are deprecated and will either generate an error or a deprecation warning (see: https://stackoverflow.com/questions/69875125/find-element-by-commands-are-deprecated-in-selenium).
All references should be replaced by the relevant By class method (see: https://selenium-python.readthedocs.io/locating-elements.html). This will resolve errors for users on newer versions of chromedriver.
FWIW – interestingly By is already in the import path of all relevant files and inconsistently used throughout. This PR should resolve those confusing inconsistencies as well (e.g. use of both find_element_by_xpath and find_element(By.XPATH in the same class).