Skip to content

Commit

Permalink
fix: Fix missing override in MetaSegmentIndex
Browse files Browse the repository at this point in the history
Methods on MetaSegmentIndex which should not be called directly should
be overridden from the base class.  Recently, a new method was added,
but not overridden in the subclass.  This adds an appropriate stub.

This omission had no effect on the player at runtime as far as we can
tell.

Change-Id: I3402aafdd2643f311944ff0497ad3a1c06db8175
  • Loading branch information
joeyparrish committed Apr 21, 2021
1 parent ef0c651 commit 1dbd75a
Showing 1 changed file with 11 additions and 1 deletion.
12 changes: 11 additions & 1 deletion lib/media/segment_index.js
Expand Up @@ -690,7 +690,6 @@ shaka.media.MetaSegmentIndex = class extends shaka.media.SegmentIndex {
false, 'merge() should not be used in MetaSegmentIndex!');
}


/**
* @override
* @export
Expand All @@ -702,6 +701,17 @@ shaka.media.MetaSegmentIndex = class extends shaka.media.SegmentIndex {
false, 'evict() should not be used in MetaSegmentIndex!');
}

/**
* @override
* @export
*/
mergeAndEvict(references, windowStart) {
// mergeAndEvict() is only used internally by the DASH and HLS parser on
// SegmentIndexes, but never on MetaSegmentIndex.
goog.asserts.assert(
false, 'mergeAndEvict() should not be used in MetaSegmentIndex!');
}

/**
* @override
* @export
Expand Down

0 comments on commit 1dbd75a

Please sign in to comment.