fix: Fix uncaught global OBJECT_DESTROYED errors

Related to shaka-project#6458
joeyparrish · Apr 19, 2024 · 6fcd14a · 6fcd14a
1 parent 1dbfafc
commit 6fcd14a
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/lib/media/media_source_engine.js b/lib/media/media_source_engine.js
@@ -1879,7 +1879,12 @@ shaka.media.MediaSourceEngine = class {
       this.destroyer_.ensureNotDestroyed();
 
       this.eventManager_.listenOnce(this.video_, 'canplaythrough', () => {
-        this.destroyer_.ensureNotDestroyed();
+        // Don't use ensureNotDestroyed() from this event listener, because
+        // that results in an uncaught exception.  Instead, just check the
+        // flag.
+        if (this.destroyer_.destroyed) {
+          return;
+        }
 
         this.video_.autoplay = previousAutoPlayState;
         if (!previousPausedState) {