Optional depends on javafx.graphics

[Glavo]

In fact, the dependence of FX Gson on javafx.graphics is optional.

Although it is rare to use java.base without depends on javafx.graphics, I think it is a good thing to reduce the mandatory dependency on other modules as much as possible in module-info.java.

[joffrey-bion]

While I understand the change for javafx.graphics, could you please elaborate on why you removed the transitive keyword for javafx.base? The reason for the very existence of this library is to manipulate JavaFX properties and related classes. What would be the point in using this library without its transitive dependencies on JavaFX types?

[Glavo]

While I understand the change for javafx.graphics, could you please elaborate on why you removed the transitive keyword for javafx.base? The reason for the very existence of this library is to manipulate JavaFX properties and related classes. What would be the point in using this library without its transitive dependencies on JavaFX types?

The main purpose of this change is to make these two requirements more "symmetrical". I think if one of them is declared as transient and the other is not, it will cause some subtle problems.

The second reason is that I believe that only when the API relies on other modules can it be declared as transient.
FxGson and FxGsonBuilder do not have API methods that take classes in javafx.base as parameters or return values, so transient is not required.

[joffrey-bion]

The main purpose of this change is to make these two requirements more "symmetrical".

They were both transient, and with this change one becomes static and the other is not. I don't understand what you mean by "more symmetrical" - if anything, they are less symmetrical now.

FxGson and FxGsonBuilder do not have API methods that take classes in javafx.base as parameters or return values, so transient is not required.

I think you mean transitive, not transient. FxGson and FxGsonBuilder don't, but other public classes of this library do. Basically all the public type adapters have JavaFX classes in their public APIs. This is why those 2 modules were declared transitive, it's the equivalent of api in Gradle jargon.

This is true for both javafx.graphics and javafx.base, actually.