Add rename features for Columnizers

It is now possible to rename a columnizer, edit its columns and regexs directly in the tables/lists.

src/main/java/org/hildan/fxlog/columns/ColumnDefinition.java

@@ -38,33 +38,25 @@ public ColumnDefinition(String headerLabel, String capturingGroupName) {
     /**
      * @return the header of this column
      */
-    public String getHeaderLabel() {
+    String getHeaderLabel() {
         return headerLabel.get();
     }
 
     public StringProperty headerLabelProperty() {
         return headerLabel;
     }
 
-    public void setHeaderLabel(String headerLabel) {
-        this.headerLabel.set(headerLabel);
-    }
-
     /**
      * @return the name of the capturing group to get the data from for this column
      */
-    public String getCapturingGroupName() {
+    String getCapturingGroupName() {
         return capturingGroupName.get();
     }
 
     public StringProperty capturingGroupNameProperty() {
         return capturingGroupName;
     }
 
-    public void setCapturingGroupName(String capturingGroupName) {
-        this.capturingGroupName.set(capturingGroupName);
-    }
-
     /**
      * @return the preferred width for this column
      */

src/main/java/org/hildan/fxlog/controllers/ColumnizersController.java

@@ -14,6 +14,8 @@
 import javafx.fxml.FXML;
 import javafx.fxml.Initializable;
 import javafx.scene.control.*;
+import javafx.scene.control.cell.*;
+import javafx.util.StringConverter;
 
 import org.hildan.fxlog.columns.ColumnDefinition;
 import org.hildan.fxlog.columns.Columnizer;
@@ -76,6 +78,22 @@ public void initialize(URL location, ResourceBundle resources) {
     private void initializeColumnizersList() {
         columnizersList.setItems(config.getColumnizers());
         columnizersList.getSelectionModel().setSelectionMode(SelectionMode.SINGLE);
+        columnizersList.setCellFactory(TextFieldListCell.forListView(new StringConverter<Columnizer>() {
+            @Override
+            public String toString(Columnizer columnizer) {
+                return columnizer.toString();
+            }
+
+            @Override
+            public Columnizer fromString(String string) {
+                // temporary object
+                return new Columnizer(string);
+            }
+        }));
+        columnizersList.setOnEditCommit(e -> {
+            Columnizer editedColumnizer = columnizersList.getItems().get(e.getIndex());
+            editedColumnizer.setName(e.getNewValue().getName());
+        });
     }
 
     private void initializeSelectedColumnizerPane() {
@@ -87,6 +105,33 @@ private void initializeSelectedColumnizerPane() {
 
     private void initializePatternsList() {
         patternList.getSelectionModel().setSelectionMode(SelectionMode.SINGLE);
+        patternList.setCellFactory(l -> new TextFieldListCell<Pattern>(new StringConverter<Pattern>() {
+            @Override
+            public String toString(Pattern pattern) {
+                return pattern.toString();
+            }
+
+            @Override
+            public Pattern fromString(String string) {
+                try {
+                    return Pattern.compile(string);
+                } catch (PatternSyntaxException e) {
+                    return null;
+                }
+            }
+        }) {
+            @Override
+            public void commitEdit(Pattern pattern) {
+                if (!isEditing()) return;
+                PseudoClass errorClass = PseudoClass.getPseudoClass("error");
+                pseudoClassStateChanged(errorClass, pattern == null);
+                if (pattern != null) {
+                    // only if the pattern is valid, otherwise we stay in edit state
+                    super.commitEdit(pattern);
+                }
+            }
+        });
+        patternList.setOnEditCommit(e -> patternList.getItems().set(e.getIndex(), e.getNewValue()));
         ListBinding<Pattern> patterns = new ListBinding<Pattern>() {
             {
                 bind(columnizersList.getSelectionModel().selectedItemProperty());
@@ -107,8 +152,15 @@ protected ObservableList<Pattern> computeValue() {
 
     private void initializeColumnsTable() {
         columnsTable.getSelectionModel().setSelectionMode(SelectionMode.SINGLE);
+        newColumnHeaderField.setMaxWidth(headerColumn.getPrefWidth());
+        newColumnGroupField.setMaxWidth(capturingGroupColumn.getPrefWidth());
+
+        headerColumn.setCellFactory(TextFieldTableCell.forTableColumn());
         headerColumn.setCellValueFactory(data -> data.getValue().headerLabelProperty());
+
+        capturingGroupColumn.setCellFactory(TextFieldTableCell.forTableColumn());
         capturingGroupColumn.setCellValueFactory(data -> data.getValue().capturingGroupNameProperty());
+
         ListBinding<ColumnDefinition> columnDefinitions = new ListBinding<ColumnDefinition>() {
             {
                 bind(columnizersList.getSelectionModel().selectedItemProperty());

src/main/resources/org/hildan/fxlog/light_theme.css

@@ -1,4 +1,9 @@
 .text-field:error {
     -fx-text-box-border: red;
     -fx-focus-color: red;
+}
+
+.list-cell:error {
+    -fx-text-box-border: red;
+    -fx-focus-color: red;
 }

src/main/resources/org/hildan/fxlog/view/columnizers.fxml

@@ -13,7 +13,7 @@
 <?import javafx.scene.layout.HBox?>
 <?import javafx.scene.layout.VBox?>
 
-<SplitPane dividerPositions="0.3" prefHeight="480.0" prefWidth="640.0" xmlns="http://javafx.com/javafx/8.0.65" xmlns:fx="http://javafx.com/fxml/1" fx:controller="org.hildan.fxlog.controllers.ColumnizersController">
+<SplitPane dividerPositions="0.3" prefHeight="600.0" prefWidth="800.0" xmlns="http://javafx.com/javafx/8.0.65" xmlns:fx="http://javafx.com/fxml/1" fx:controller="org.hildan.fxlog.controllers.ColumnizersController">
   <items>
       <BorderPane>
          <center>