Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add real support for websocket messages API #3

Closed
joffrey-bion opened this issue Aug 13, 2017 · 0 comments
Closed

Add real support for websocket messages API #3

joffrey-bion opened this issue Aug 13, 2017 · 0 comments
Labels
enhancement
Projects
Livedoc Backend
Milestone
5.0.0

Comments

@joffrey-bion
Copy link
Owner

joffrey-bion commented Aug 13, 2017 •
edited
Loading

The @MessageMapping and @SubscribeMapping annotations should not be used to filled the same kind of doc object as the request mappings. They should be displayed differently in the UI so that the user understands that it is websocket API, and not HTTP requests.

Also, the playground should be disabled for such endpoints, or upgraded to deal with websockets.
@joffrey-bion joffrey-bion changed the title Add support for websocket annotations scan Add support for websocket messages API Aug 13, 2017
@joffrey-bion joffrey-bion mentioned this issue Aug 15, 2017
Closed
@joffrey-bion joffrey-bion added this to TODO in Livedoc Backend Mar 9, 2018
joffrey-bion added a commit that referenced this issue May 6, 2018
@joffrey-bion
Add actual bidirectional messages support
75aaf70 
Websocket messages were so far stuffed into the same structure as API
operations, which is definitely not ideal. A message is not described by
the same things as an operation and should be treated separately.

The library now uses a different representation and can read more
details about messages. The UI has been adapted to display these
messages separately from the API operations.

Resolves:
#3
joffrey-bion added a commit that referenced this issue May 7, 2018
@joffrey-bion
Add actual bidirectional messages support
b548da9 
Websocket messages were so far stuffed into the same structure as API
operations, which is definitely not ideal. A message is not described by
the same things as an operation and should be treated separately.

The library now uses a different representation and can read more
details about messages. The UI has been adapted to display these
messages separately from the API operations.

Resolves:
#3
@joffrey-bion joffrey-bion changed the title Add support for websocket messages API Add real support for websocket messages API May 8, 2018
@joffrey-bion joffrey-bion moved this from TODO to In Progress in Livedoc Backend May 8, 2018
@joffrey-bion joffrey-bion added this to the 5.0.0 milestone May 9, 2018
@joffrey-bion joffrey-bion moved this from In Progress to Done in Livedoc Backend May 10, 2018
@joffrey-bion joffrey-bion moved this from Done to In Progress in Livedoc Backend May 10, 2018
Livedoc Backend automation moved this from In Progress to Done May 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
Livedoc Backend
  
Done
Milestone
5.0.0
Development

No branches or pull requests
1 participant
@joffrey-bion