Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumped dependencies to support Flutter 3 with Dart 3 #58

Merged
merged 4 commits into from
Jul 7, 2023

Conversation

AngeloAvv
Copy link
Contributor

@AngeloAvv AngeloAvv commented Jul 6, 2023

If you use connectivity_plus for other purposes, you cannot use the latest versions supported by Flutter3 and Dart 3.
I took the chance to bump the dependencies for this awesome package as it's not been updated for a while.

I also updated the CI script, If you want me to perform some changes, feel free to point them out here.

Closes #57

@jogboms
Copy link
Owner

jogboms commented Jul 7, 2023

Hey @AngeloAvv
This is really thoughtful of you but I would prefer the version to be v3.0.0 due to the sdk update

@AngeloAvv
Copy link
Contributor Author

Done! ✅

Copy link
Owner

@jogboms jogboms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @AngeloAvv

@codecov
Copy link

codecov bot commented Jul 7, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (72bc05b) 100.00% compared to head (ec6317a) 100.00%.

❗ Current head ec6317a differs from pull request most recent head 28c1d2d. Consider uploading reports for the commit 28c1d2d to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##            master       #58   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines           49        49           
=========================================
  Hits            49        49           
Impacted Files Coverage Δ
lib/src/utils.dart 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jogboms jogboms enabled auto-merge July 7, 2023 15:24
@jogboms jogboms merged commit b986352 into jogboms:master Jul 7, 2023
1 check passed
@AngeloAvv AngeloAvv deleted the dart_3_dependencies branch July 7, 2023 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

depend on network_info_plus: ^4.0.0
2 participants