Fix wrong assertion when equal #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #61 +/- ##
=======================================
Coverage 99.80% 99.80%
=======================================
Files 2 2
Lines 516 525 +9
=======================================
+ Hits 515 524 +9
Misses 1 1
Help us with your feedback. Take ten seconds to tell us how you rate us. |
jogboms
approved these changes
Aug 2, 2022
|
@FMorschel this doesn't apply to |
|
Missed it! Sorry! Forgot about the |
|
Thanks for picking it up @FMorschel |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found a bug. When both
minandmaxwere equal, the assertion was throwing. Added a test to maintain that as well. The documentation above was correct, must have missed it when publishing the first time.