publish CtlInfo struct #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabianfreyer
force-pushed
the
expose_ctlinfo
branch
from
1ba92cf
to
3c487fc
Compare
fabianfreyer
force-pushed
the
expose_ctlinfo
branch
from
3c487fc
to
c978945
Compare
|
I've fixed tests on macos and a cherry-picked version of this on top of #20 gives green builds on macos too. |
Use std::ffi::CStr to parse the string, which handles terminating Nul-bytes correctly.
This was referenced Dec 23, 2018
Closed
|
Thanks for this! I will try to find time this week to play around with all the new features and publish a new version. |
|
Awesome, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One way of implementing #18.
This wasn't tested on macos.If you do decide to merge this, it would be great if you could then also bump the version and publish 0.3.0 to crates.io :)