Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AuthMethod to Vault issuer #103

Merged
merged 2 commits into from
Dec 22, 2019
Merged

Conversation

johanbrandhorst
Copy link
Owner

Add AuthMethod to Vault issuer

AuthMethod replaces the Token field. It is used to
configure the token used for the Vault API requests.
ConstantToken is equivalent to the old Token field.

AuthMethod replaces the Token field. It is used to
configure the token used for the Vault API requests.
ConstantToken is equivalent to the old Token field.
@codecov
Copy link

codecov bot commented Dec 22, 2019

Codecov Report

Merging #103 into master will increase coverage by 0.15%.
The diff coverage is 77.77%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #103      +/-   ##
==========================================
+ Coverage   66.29%   66.44%   +0.15%     
==========================================
  Files          10       10              
  Lines         448      456       +8     
==========================================
+ Hits          297      303       +6     
- Misses         99      100       +1     
- Partials       52       53       +1
Impacted Files Coverage Δ
issuer.go 85.71% <ø> (ø) ⬆️
issuers/vault/types.go 100% <100%> (ø) ⬆️
issuers/vault/vault.go 61.33% <71.42%> (+0.46%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5bb6ad6...c6d2823. Read the comment docs.

@johanbrandhorst johanbrandhorst merged commit 3e933cc into master Dec 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant