Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use certificate name as singleflight key #131

Merged
merged 1 commit into from
Aug 22, 2021

Conversation

johanbrandhorst
Copy link
Owner

Fixes #130

@codecov
Copy link

codecov bot commented Aug 22, 2021

Codecov Report

Merging #131 (f65f387) into master (0b4cf6d) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #131   +/-   ##
=======================================
  Coverage   63.98%   63.98%           
=======================================
  Files          10       10           
  Lines         547      547           
=======================================
  Hits          350      350           
  Misses        130      130           
  Partials       67       67           
Impacted Files Coverage Δ
certify.go 63.63% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b4cf6d...f65f387. Read the comment docs.

@johanbrandhorst johanbrandhorst merged commit f590652 into master Aug 22, 2021
@johanbrandhorst johanbrandhorst deleted the correct-use-of-singleflight branch August 22, 2021 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

improper use of singleflight
1 participant