Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Implement Apply Server Side #10

Open
johandry opened this issue Mar 11, 2020 · 1 comment
Open

[Feature] Implement Apply Server Side #10

johandry opened this issue Mar 11, 2020 · 1 comment
Assignees

Comments

@johandry
Copy link
Owner

Is your feature request related to a problem? Please describe.
Not problem related

Describe the solution you'd like
Implement a method ApplyServerSide() or similar name, to allow execute the apply using service side. This is done in kubectl with the flag --server-side. This feature is new (beta) in K8s 1.16, more about it here: https://kubernetes.io/docs/reference/using-api/api-concepts/#server-side-apply

Describe alternatives you've considered
The current Apply*() methods

Proposal
Check the kubectl/pkg/cmd/apply/apply.go before implement it, it's in beta now so it may change. If Server Side is enabled it's similar to the other services: get the helper and use the method Patch() passing some options. It does not require to create the patcher.

Additional context
It's beta in v.1.16, wait until it's declared stable or implement it and make a note about its state.

References
None

@johandry johandry self-assigned this Mar 11, 2020
@kwiesmueller
Copy link

Hey there,
this came up in a GitHub search for Server-Side Apply.
If you need any help with this or encounter problems while implementing, feel free to get in touch.
As far as i've read, you're using json so you shouldn't encounter big problems. We are also investigating how to add Server-Side Apply to client-go, but in general it already works through the patch method.
You can find us (wg-api-expression) on the Kubernetes Slack https://kubernetes.slack.com/archives/C0123CNN8F3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants