Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port to Bevy 0.11 #28

Merged
merged 21 commits into from
Aug 11, 2023
Merged

Port to Bevy 0.11 #28

merged 21 commits into from
Aug 11, 2023

Conversation

johanhelsing
Copy link
Owner

@johanhelsing johanhelsing commented Jul 13, 2023 •
edited

Builds on #27

  • get rid of ghetto namespacing (sd_) at least where it doesn't make sense as an abbreviation for signed distance.

@johanhelsing johanhelsing added the enhancement New feature or request label Jul 13, 2023
@johanhelsing
Copy link
Owner Author

Everything is now working again... however there are some unanswered questions:

  1. Are we happy with the shapes:: import style API? It's a lot more tedious to use now, see the star_bevy.wgsl and bevy.wgsl diffs
  2. Maybe move some of the helper functions into appropriately named modules?
  3. Should we do anything to remove the trailing underscores from public API items?

Perhaps the simplest solution is to move everything to a root-level bevy_smud import?

johanhelsing
johanhelsing commented Jul 13, 2023
View reviewed changes
src/lib.rs Outdated
"#
));
),
file!(),
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should probably include generated id here?

@johanhelsing johanhelsing merged commit 5df3bd5 into main Aug 11, 2023
3 checks passed
@johanhelsing johanhelsing deleted the bevy-0.11 branch August 11, 2023 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dimchikkk Dimchikkk Dimchikkk left review comments

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@johanhelsing @Dimchikkk