Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle http error codes #7

Open
johanhelsing opened this issue Sep 23, 2022 · 0 comments
Open

Handle http error codes #7

johanhelsing opened this issue Sep 23, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@johanhelsing
Copy link
Owner

johanhelsing commented Sep 23, 2022 •
edited

Currently, if the response is a http error, we just blindly pass the payload on to the asset loader, which will most likely fail.

On certain http error codes it probably makes sense to retry, on others it probably makes sense to log a warning/error and return and AssetIoError.

Split from: #4
Related to: #6
@johanhelsing johanhelsing added the enhancement New feature or request label Sep 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@johanhelsing