ocasional panic

[gilescope]

The unwrap here is causing a panic occasionally:

bevy_web_asset/src/web_asset_io.rs

Line 26 in d4cd4f4

let resp_value = JsFuture::from(window.fetch_with_str(uri)).await.unwrap();

panicked at 'called `Result::unwrap()` on an `Err` value: JsValue(TypeError: NetworkError when attempting to fetch resource.
)', /home/gilescope/.cargo/registry/src/github.com-1ecc6299db9ec823/bevy_web_asset-0.4.0/src/web_asset_io.rs:26:83

[johanhelsing]

Thanks. I guess warning and retrying after a small timeout is probably the best thing to do in most cases?

We could do that as first measure, then add special casing for various http 4xx and 5xx codes later.

[gilescope]

Sounds perfect! I guess it depends on the status code as to if it’s sensible to retry.

…

On Tue, 20 Sep 2022 at 08:01, Johan Klokkhammer Helsing < ***@***.***> wrote: Thanks. I guess warning and retrying after a small timeout is probably the best thing to do in most cases? We could do that as first measure, then add special casing for various http 4xx and 5xx codes later. — Reply to this email directly, view it on GitHub <#4 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAGEJCA6JC3W43TNSEH232TV7FONJANCNFSM6AAAAAAQQXRU6U> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[johanhelsing]

I fixed the panic at least. Don't have time to look into retrying now, but created new issues for that.