Wrong position on fixed element and inside fixed element.

[Narretz]

I've tried to use it on a fixed position element and on the first child of a fixed position element.
Fixed position doesn't work at all (element is skipped?) and inside fixed position, the positioning is wrong.

[Narretz]

I've tried document.getBoundingClientRect() to get the correct "hole", and this seems to work quite well

[johanlahti]

Thanks a lot for the feedback. I had a quick look at it and getBoundingClient seems to work fine. However, fixed elements are skipped because of the way the visibility of elements is determined. I might borrow this logic from jquery instead (or elsewhere… open for suggestions).

I will look at the other issues when I have some time over.

[Narretz]

Great to hear. Tbh, I think the developer should make sure his tour elements are visible / can be scrolled to.

I think this library is very promising, although I've had to make a lot of modifications locally to make it suit my requirements. I hope to give something back in the form of pull requests. :D Alas, the time is the problem ...

[johanlahti]

It would be great with some contributions or even re-writes of some parts. I must admit the library is very "shaky" at the moment and not ready for use (should maybe emphasise this in the Readme).

Regarding the visibility, I agree the developer should make sure elements are visible. However, when applying responsive design patterns with CSS breakpoints, elements can be hidden on some screen sizes or hidden/shown on resize. In those cases it would be nice to skip to the next/previous slide.

Happy to hear you also see the potential in this library. You may have come across Intro.js which is very nice but in my opinion:

• Is limited by its license in some cases
• Design and interaction feels slightly old already (even though I bet it can be customised)
• A little too complex (or too many features?)
• It manipulates the rendered elements, raising z-index and changing style

The latter is avoided by adding a canvas on top. From my point of view, the library should be:

1. As minimalistic as possible but do only what it's supposed to really well (i.e. introduce the site/app to the user)
2. Easily extensible as opposed to offering many options
3. Not modify the elements being visualised (unless it's part of the tutorial)

I think and hope point 1 and 2 goes inline with the limited time… :D

[Narretz]

I absolutely agree with all your points! Like I described in the other issue I would also extend the minimalistic part to the use of the templates / elements.