Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for chunk upload signatures #50

Merged
merged 3 commits into from
Feb 4, 2021

Conversation

leoleoasd
Copy link
Contributor

Fixes #49

@johannesboyne
Copy link
Owner

Hi @leoleoasd, THANK! you for the contribution.

Seems like a great addition to support AWS Signature Version 4 Chunk Upload and by taking a first read through the code it looks good and straight forward. IMO, the newly introduced file chunk.go could easily get a nice test case. This will make codecov happy ;-)
See https://github.com/johannesboyne/gofakes3/blob/master/uploader_test.go#L10 for an example.
What do you think?

@leoleoasd
Copy link
Contributor Author

Okay, sure do!

@sonarcloud
Copy link

sonarcloud bot commented Feb 4, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@leoleoasd
Copy link
Contributor Author

Covered chunk.go 100%

@johannesboyne johannesboyne merged commit ecdfbfd into johannesboyne:master Feb 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: support AWS Signature Version 4 Chunk Upload
2 participants