Skip to content

Commit

Permalink
Only test MSRV with minimal versions
Browse files Browse the repository at this point in the history
  • Loading branch information
MarijnS95 committed Jan 31, 2024
1 parent aba88fb commit 02eda66
Show file tree
Hide file tree
Showing 2 changed files with 18 additions and 15 deletions.
28 changes: 16 additions & 12 deletions .github/workflows/rust.yml
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,11 @@ jobs:
run: cargo test --verbose

verify-msrv:
runs-on: ubuntu-latest
name: verify minimum supported rust version (ubuntu)
strategy:
matrix:
os: [ubuntu-latest]
runs-on: ${{ matrix.os }}
name: verify minimum supported rust version without cache (takes longer, but caching produces unexpected behaviour)
timeout-minutes: 30

# we are using the `cargo-msrv` app
Expand All @@ -47,14 +50,15 @@ jobs:
steps:
- uses: actions/checkout@v2

- name: Install foresterre/cargo-msrv without cache (takes longer, but caching produces unexpected behaviour)
- name: Install foresterre/cargo-msrv
run: cargo install cargo-msrv

- name: Verify the Rustc version declared in `cargo.toml` without cache (takes longer, but caching produces unexpected behaviour)
run: |
rm -f Cargo.lock
cargo update
cargo-msrv verify
- uses: dtolnay/rust-toolchain@nightly
- name: Generate Cargo.lock with minimal-version dependencies
run: cargo -Zminimal-versions generate-lockfile

- name: Verify the Rustc version declared in `Cargo.toml` with `minimal-versions`
run: cargo-msrv verify

# github actions does not support big endian systems directly, but it does support QEMU.
# so we use cross-rs, which uses QEMU internally.
Expand Down Expand Up @@ -94,16 +98,16 @@ jobs:

steps:
- uses: actions/checkout@v2

- name: Cache Cargo Dependencies
uses: Swatinem/rust-cache@v1.3.0

- name: Add wasm32 Target
run: rustup target add wasm32-unknown-unknown

- name: Build without default features
run: cargo build --verbose --no-default-features --target wasm32-unknown-unknown

- name: Run tests without default features
run: cargo test --verbose --no-default-features

5 changes: 2 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -29,9 +29,8 @@ Features include:
### Current Status

> [!TIP]
> MSRV Note: This crate is now on Rust `1.70.0`. If you want to use the
> newest version of `exrs` with an older Rust version, you can still do that:
> By specifying a version `half = "2.1.0"` in your project, the crate will work with Rust `1.59.0`.
> MSRV Note: This crate is now on Rust `1.70.0`.
> If you want to use the newest version of `exrs` with an older Rust version, you can still do that, by forcing Rust to use a an older version of the `half` crate via `cargo update -p half --precise 2.2.1`. `half 2.3.0` and higher have an MSRV above 1.61.
This library has matured quite a bit, but should still be considered incomplete.
For example, deep data and DWA compression algorithms are not supported yet.
Expand Down

0 comments on commit 02eda66

Please sign in to comment.